Three long-press features#211
Open
sastraxi wants to merge 11 commits into
Open
Conversation
Cut verbose comments and drop PLAN.md / "Feature N" references. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Replace the bare dict with LongpressActionConfig (TypedDict), cast once at the YAML parse boundary in set_longpress_groups. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts: # tests/v3/test_audio_midi_panel.py # uilib/glyphs/audio_midi_tile.py
# Conflicts: # pistomp/controller_manager.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long-press emits a raw MIDI CC
Fires RawMidiCcEffect(channel, cc) on long-press. First press sends 127, alternates thereafter. Uses fs.midi_channel + the dict's midi_CC; the footswitch's midi_CC (sibling to longpress) remains scoped to short-press. The footswitch LED stays in its PRESS role; the plugin tile reconciles via mod-ui's WS echo.
Long-press selects a snapshot
Reuses the existing PresetEffect on a LONGPRESS row. Specific index → preset_set_and_change; UP/DOWN → incr/decr.
Long-press scrolls pedalboards in-bank
New PedalboardEffect walks the current bank's ordered list with wraparound, falling back to the full alphabetical pedalboard_list when no bank is set.
Supporting changes