chore(tests): keep maintained coverage independent of TCP

[yordis]

• Preserves maintained core coverage on the supported client path.

[cursor]

PR Summary

Low Risk
Changes are confined to test projects and helpers; production behavior is not modified in this diff.

Overview
Maintained core tests no longer depend on the legacy TCP client or TCP readiness checks. Coverage now exercises the supported gRPC/HTTPS path (append, read, subscriptions, scavenge verification, transforms, enumerator scenarios) via shared helpers on TestFixtureWithMiniNodeConnection.

Test infrastructure: adds TestCertificates (replacing ssl_connections) and switches several fixtures to EventStore.Common.Utils / EventStore.Core.Data types instead of EventStore.ClientAPI. MiniNode restarts and startup tests use HTTP endpoints only; TCP plugin configuration is removed from vnode startup tests.

Removed or narrowed coverage: drops the follower via_tcp integration case, the ignored ClientAPI persistent-subscription deadlock test, and TCP-based readiness gates in health/authorization setup. Legacy policy verification no longer treats Operations.Node.Statistics.Tcp as anonymously accessible. Cluster/TLS option tests drop internal/external TCP endpoint and gossip advertise assertions.

Other test updates: storage reader filter tests use EventFilter.EventType / StreamName helpers instead of protobuf Filter; replication test class renamed to when_replica_subscribes; a few gRPC tests send raw JSON metadata instead of ClientAPI helpers.

^{Reviewed by Cursor Bugbot for commit 559f3ec. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 2f61ea59-fd33-4db1-bb2d-ed1089b0de64

📥 Commits

Reviewing files that changed from the base of the PR and between 2c5b834 and 559f3ec.

📒 Files selected for processing (32)

• src/EventStore.Core.Tests/Authorization/LegacyPolicyVerification.cs
• src/EventStore.Core.Tests/ClientOperations/specification_with_bare_vnode.cs
• src/EventStore.Core.Tests/ClientOperations/when_committing_a_transaction_with_data.cs
• src/EventStore.Core.Tests/Helpers/TestCertificates.cs
• src/EventStore.Core.Tests/Helpers/TestFixtureWithExistingEvents.cs
• src/EventStore.Core.Tests/Http/HealthChecks/when_performing_a_live_check.cs
• src/EventStore.Core.Tests/Integration/authenticated_requests_made_from_a_follower.cs
• src/EventStore.Core.Tests/Integration/specification_with_a_single_node.cs
• src/EventStore.Core.Tests/Integration/when_a_single_node_is_restarted_multiple_times.cs
• src/EventStore.Core.Tests/Services/PersistentSubscription/PersistentSubscriptionTests.cs
• src/EventStore.Core.Tests/Services/Replication/LeaderReplication/when_replica_subscribes.cs
• src/EventStore.Core.Tests/Services/RequestManagement/Service/RequestManagerServiceSpecification.cs
• src/EventStore.Core.Tests/Services/Storage/AllReader/when_reading_all_with_disallowed_streams.cs
• src/EventStore.Core.Tests/Services/Storage/AllReader/when_reading_all_with_filtering.cs
• src/EventStore.Core.Tests/Services/Storage/HashCollisions/with_hash_collisions.cs
• src/EventStore.Core.Tests/Services/Storage/Scavenge/when_running_a_scavenge_from_storage_scavenger.cs
• src/EventStore.Core.Tests/Services/Transport/Enumerators/Enumerator.AllSubscription.CombinationTests.cs
• src/EventStore.Core.Tests/Services/Transport/Enumerators/Enumerator.AllSubscriptionFiltered.CombinationTests.cs
• src/EventStore.Core.Tests/Services/Transport/Enumerators/Enumerator.CombinationTests.cs
• src/EventStore.Core.Tests/Services/Transport/Enumerators/Enumerator.StreamSubscription.CombinationTests.cs
• src/EventStore.Core.Tests/Services/Transport/Grpc/StreamsTests/DeleteTests.cs
• src/EventStore.Core.Tests/Services/Transport/Grpc/StreamsTests/ReadStreamsForwardTests.cs
• src/EventStore.Core.Tests/Services/Transport/Http/Authorization/authorization_tests.cs
• src/EventStore.Core.Tests/Services/UserManagementService/user_management_service.cs
• src/EventStore.Core.Tests/Services/VNode/startup_should.cs
• src/EventStore.Core.Tests/TransactionLog/Truncation/when_truncating_database.cs
• src/EventStore.Core.Tests/Transforms/TransformTests.cs
• src/EventStore.Core.XUnit.Tests/Configuration/ClusterNodeOptionsTests/ClusterVNodeOptionsScenarios.cs
• src/EventStore.Core.XUnit.Tests/Configuration/ClusterNodeOptionsTests/when_building/with_cluster_node_and_custom_settings.cs
• src/EventStore.Core.XUnit.Tests/Configuration/ClusterNodeOptionsTests/when_building/with_single_node_and_custom_settings.cs
• src/EventStore.Core.XUnit.Tests/Configuration/ClusterNodeOptionsTests/when_building/with_tls.cs
• src/EventStore.Core.XUnit.Tests/Configuration/ClusterNodeOptionsTests/when_shutting_down_an_isolated_cluster_member.cs

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit bf237a2. Configure here.}