Skip to content

chore(transport): retire the legacy TCP package - #498

Open
yordis wants to merge 1 commit into
yordis/feat-grpc-connection-observabilityfrom
yordis/chore-remove-legacy-tcp-package
Open

yordis wants to merge 1 commit into
yordis/feat-grpc-connection-observabilityfrom
yordis/chore-remove-legacy-tcp-package

Conversation

@yordis

@yordis yordis commented Sep 12, 2026

Copy link
Copy Markdown
Member
  • Prevents the retired transport from remaining buildable or distributable by accident.

@yordis
yordis requested a review from a team as a code owner September 12, 2026 23:22
@cursor

cursor Bot commented Sep 12, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Removes networking/SSL transport code that could still be referenced externally; in-repo references appear gone, but downstream consumers of the TCP library would break.

Overview
Retires the legacy EventStore.Transport.Tcp project so it can no longer be built or shipped from this repo. The change deletes the full TCP stack (plain and SSL connections, listeners, length-prefix framing, formatters, monitoring) and drops the project from EventStore.sln.

Central package management no longer pins EventStore.Client (v21.2.0), aligning dependencies with the remaining gRPC client packages already listed in Directory.Packages.props.

Reviewed by Cursor Bugbot for commit 8d3a13b. Bugbot is set up for automated code reviews on this repo. Configure here.

@yordis
yordis added this pull request to stack #500 September 12, 2026 23:22
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 7e10efa5-c667-4e67-aeb0-95a4c84c17a8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 61a5de91-1e9a-4618-b463-3d562fa0cf4d

📥 Commits

Reviewing files that changed from the base of the PR and between ab718f7 and 2b3ea9b.

📒 Files selected for processing (23)
  • src/Directory.Packages.props
  • src/EventStore.Transport.Tcp/EventStore.Transport.Tcp.csproj
  • src/EventStore.Transport.Tcp/Formatting/FormatterBase.cs
  • src/EventStore.Transport.Tcp/Formatting/IMessageFormatter.cs
  • src/EventStore.Transport.Tcp/Formatting/RawMessageFormatter.cs
  • src/EventStore.Transport.Tcp/Framing/IMessageFramer.cs
  • src/EventStore.Transport.Tcp/Framing/LengthPrefixMessageFramer.cs
  • src/EventStore.Transport.Tcp/Framing/LengthPrefixMessageFramerWithBufferPool.cs
  • src/EventStore.Transport.Tcp/Framing/PackageFramingException.cs
  • src/EventStore.Transport.Tcp/Helper.cs
  • src/EventStore.Transport.Tcp/IMonitoredTcpConnection.cs
  • src/EventStore.Transport.Tcp/ITcpConnection.cs
  • src/EventStore.Transport.Tcp/SocketArgsPool.cs
  • src/EventStore.Transport.Tcp/TcpClientConnector.cs
  • src/EventStore.Transport.Tcp/TcpConfiguration.cs
  • src/EventStore.Transport.Tcp/TcpConnection.cs
  • src/EventStore.Transport.Tcp/TcpConnectionBase.cs
  • src/EventStore.Transport.Tcp/TcpConnectionMonitor.cs
  • src/EventStore.Transport.Tcp/TcpConnectionSsl.cs
  • src/EventStore.Transport.Tcp/TcpServerListener.cs
  • src/EventStore.Transport.Tcp/TcpStats.cs
  • src/EventStore.Transport.Tcp/TcpTypedConnection.cs
  • src/EventStore.sln
💤 Files with no reviewable changes (23)
  • src/EventStore.Transport.Tcp/Formatting/RawMessageFormatter.cs
  • src/EventStore.Transport.Tcp/Framing/LengthPrefixMessageFramerWithBufferPool.cs
  • src/EventStore.Transport.Tcp/EventStore.Transport.Tcp.csproj
  • src/EventStore.Transport.Tcp/TcpTypedConnection.cs
  • src/EventStore.Transport.Tcp/TcpConnection.cs
  • src/EventStore.Transport.Tcp/TcpConnectionSsl.cs
  • src/EventStore.Transport.Tcp/TcpServerListener.cs
  • src/EventStore.Transport.Tcp/TcpConfiguration.cs
  • src/EventStore.sln
  • src/EventStore.Transport.Tcp/IMonitoredTcpConnection.cs
  • src/EventStore.Transport.Tcp/Framing/IMessageFramer.cs
  • src/EventStore.Transport.Tcp/Framing/PackageFramingException.cs
  • src/EventStore.Transport.Tcp/TcpConnectionBase.cs
  • src/EventStore.Transport.Tcp/ITcpConnection.cs
  • src/EventStore.Transport.Tcp/TcpClientConnector.cs
  • src/EventStore.Transport.Tcp/SocketArgsPool.cs
  • src/EventStore.Transport.Tcp/TcpStats.cs
  • src/EventStore.Transport.Tcp/Formatting/FormatterBase.cs
  • src/EventStore.Transport.Tcp/Framing/LengthPrefixMessageFramer.cs
  • src/Directory.Packages.props
  • src/EventStore.Transport.Tcp/Formatting/IMessageFormatter.cs
  • src/EventStore.Transport.Tcp/TcpConnectionMonitor.cs
  • src/EventStore.Transport.Tcp/Helper.cs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The pull request removes the EventStore.Transport.Tcp project and all its formatting, framing, connection, listener, SSL, pooling, configuration, monitoring, and statistics code. It also removes the project from the solution and removes one central package version entry.

Changes

TCP transport removal

Layer / File(s) Summary
Project and solution removal
src/Directory.Packages.props, src/EventStore.Transport.Tcp/EventStore.Transport.Tcp.csproj, src/EventStore.sln
The EventStore.Transport.Tcp project and its solution configuration entries are removed. The central EventStore.Client version entry is also removed.
Formatting and framing removal
src/EventStore.Transport.Tcp/Formatting/*, src/EventStore.Transport.Tcp/Framing/*
Formatter interfaces and implementations, length-prefix framers, and PackageFramingException are deleted.
Connection and monitoring removal
src/EventStore.Transport.Tcp/ITcpConnection.cs, src/EventStore.Transport.Tcp/IMonitoredTcpConnection.cs, src/EventStore.Transport.Tcp/Tcp*.cs, src/EventStore.Transport.Tcp/SocketArgsPool.cs, src/EventStore.Transport.Tcp/Helper.cs
TCP and SSL connections, client and server socket handling, pooling, configuration, monitoring, statistics, helper methods, and typed connection wrapping are deleted.

Priority: ⬇️ Low

Estimated code review effort: 4 (Complex) | ~45 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 2b3ea

The removed transport project has no remaining tracked project, restore, packaging, or compilation references. No confirmed merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: retirement of the legacy TCP transport package.
Description check ✅ Passed The description accurately states that the changes prevent the retired transport from remaining buildable or distributable.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yordis/chore-remove-legacy-tcp-package

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit reads each line,
The patch grows clear beneath the moon,
Small changes hop in place,
Tests guard the garden path,
Reviews bloom before the dawn.

Comment @coderabbitai help to get the list of available commands.

@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch 2 times, most recently from eb57a53 to aecb79b Compare September 13, 2026 00:33
@yordis
yordis force-pushed the yordis/feat-grpc-connection-observability branch 2 times, most recently from 611f2d1 to e076174 Compare September 13, 2026 00:58
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from aecb79b to 6c8c952 Compare September 13, 2026 00:58
@yordis
yordis force-pushed the yordis/feat-grpc-connection-observability branch from e076174 to a2e6f28 Compare September 13, 2026 01:16
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch 2 times, most recently from b59fac7 to e2ed620 Compare September 13, 2026 01:31
@yordis
yordis force-pushed the yordis/feat-grpc-connection-observability branch 2 times, most recently from 0388f55 to 4edf1c7 Compare September 13, 2026 01:46
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from e2ed620 to 75e1a84 Compare September 13, 2026 01:46
@yordis
yordis force-pushed the yordis/feat-grpc-connection-observability branch from 4edf1c7 to ab718f7 Compare September 13, 2026 02:04
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from 75e1a84 to 2b3ea9b Compare September 13, 2026 02:04
@yordis
yordis force-pushed the yordis/feat-grpc-connection-observability branch from ab718f7 to ea44f29 Compare September 13, 2026 02:29
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from 2b3ea9b to 55dbee6 Compare September 13, 2026 02:29
@yordis
yordis force-pushed the yordis/feat-grpc-connection-observability branch from ea44f29 to f7af60a Compare September 13, 2026 02:59
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from 55dbee6 to 1a6764d Compare September 13, 2026 02:59
@yordis
yordis force-pushed the yordis/feat-grpc-connection-observability branch from f7af60a to bcf499c Compare September 13, 2026 03:14
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch 2 times, most recently from bc7052f to bc1674b Compare September 13, 2026 03:46
@yordis
yordis force-pushed the yordis/feat-grpc-connection-observability branch from bcf499c to 5d57e44 Compare September 13, 2026 03:46
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from bc1674b to a6da954 Compare September 13, 2026 04:23
@yordis
yordis force-pushed the yordis/feat-grpc-connection-observability branch from 5d57e44 to 3840b14 Compare September 13, 2026 04:23
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from a6da954 to e255edb Compare September 13, 2026 06:04
@yordis
yordis force-pushed the yordis/feat-grpc-connection-observability branch 2 times, most recently from 8d16f1b to 5e57c7d Compare September 13, 2026 18:21
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from e255edb to 38edb52 Compare September 13, 2026 18:21
@yordis
yordis force-pushed the yordis/feat-grpc-connection-observability branch from 5e57c7d to a36811b Compare September 13, 2026 21:00
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from 38edb52 to 39a8db8 Compare September 13, 2026 21:00
@yordis
yordis removed this pull request from stack #500 September 17, 2026 01:12
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from 39a8db8 to 8c82a62 Compare September 17, 2026 01:14
@yordis
yordis force-pushed the yordis/feat-grpc-connection-observability branch 2 times, most recently from 3f16370 to 47e72be Compare September 17, 2026 01:23
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch 3 times, most recently from f0042a1 to c4bb749 Compare September 17, 2026 02:37
@yordis
yordis force-pushed the yordis/feat-grpc-connection-observability branch from 3a8ef36 to 7f58d76 Compare September 17, 2026 02:37
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from c4bb749 to 8b4cd00 Compare September 17, 2026 03:26
@yordis
yordis force-pushed the yordis/feat-grpc-connection-observability branch from 7f58d76 to 883cb11 Compare September 17, 2026 03:26
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from 8b4cd00 to 7d1e3b4 Compare September 17, 2026 04:25
@yordis
yordis force-pushed the yordis/feat-grpc-connection-observability branch from 883cb11 to 083859f Compare September 17, 2026 04:25
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from 7d1e3b4 to 98caa26 Compare September 17, 2026 22:47
@yordis
yordis force-pushed the yordis/feat-grpc-connection-observability branch 2 times, most recently from 5d20cae to b4d72cd Compare September 17, 2026 22:57
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from 98caa26 to 569dd1e Compare September 17, 2026 22:57
@yordis
yordis force-pushed the yordis/feat-grpc-connection-observability branch from b4d72cd to 54eb464 Compare September 17, 2026 23:43
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch 2 times, most recently from bb5d1f0 to fa7b8b5 Compare September 18, 2026 00:26
@yordis
yordis force-pushed the yordis/feat-grpc-connection-observability branch from 54eb464 to a7ba399 Compare September 18, 2026 00:26
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from fa7b8b5 to e4ecb11 Compare September 18, 2026 00:44
@yordis
yordis force-pushed the yordis/feat-grpc-connection-observability branch from a7ba399 to 8ef5e5c Compare September 18, 2026 00:44
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from e4ecb11 to 5268346 Compare September 18, 2026 00:49
@yordis
yordis force-pushed the yordis/feat-grpc-connection-observability branch from 8ef5e5c to 2f94ece Compare September 18, 2026 00:49
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis force-pushed the yordis/feat-grpc-connection-observability branch from 2f94ece to a009b4a Compare September 18, 2026 01:43
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from 5268346 to 8d3a13b Compare September 18, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant