fix(ui5-dynamic-page): prevent scroll jump on TableRowAction focus#13698
Open
plamenivanov91 wants to merge 8 commits into
Open
fix(ui5-dynamic-page): prevent scroll jump on TableRowAction focus#13698plamenivanov91 wants to merge 8 commits into
plamenivanov91 wants to merge 8 commits into
Conversation
When an element inside a web component (e.g. the overflow button in ui5-table-row) received focus, onContentFocusIn was scrolling using e.target - the retargeted light DOM host - instead of the actual focused element. For a tall row, this caused an unwanted scroll even when the button itself was fully visible. Two changes: - Use e.composedPath()[0] to get the real focused element (captured synchronously before RAF, where composedPath() returns []) - Only call scrollIntoView when the element is actually obscured behind the sticky header or footer, not unconditionally Fixes #13694
plamenivanov91
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
|
🚀 Deployed on https://pr-13698--ui5-webcomponents-preview.netlify.app |
plamenivanov91
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
plamenivanov91
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
NakataCode
reviewed
Jun 18, 2026
plamenivanov91
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
…-with-table-fix' into dp-redundant-scroll-with-table-fix
plamenivanov91
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
plamenivanov91
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
NakataCode
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an element inside a web component (e.g. the overflow button in ui5-table-row) received focus, onContentFocusIn was scrolling using e.target - the retargeted light DOM host - instead of the actual focused element. For a tall row, this caused an unwanted scroll even when the button itself was fully visible.
Two changes:
Fixes #13694