trunk shadow changes: com.unity.mobile.android-logcat - #215
pets-svc[bot] wants to merge 1 commit into
Conversation
| "System", | ||
| "System.Xml.Linq", | ||
| "UnityEngine.IMGUIModule", | ||
| "UnityEngine.UICommonModule", |
There was a problem hiding this comment.
expectedReferences is an exact list: the loop below requires every entry to occur once. These new compiler-generated dependencies are unconditionally required even though the package is validated on 2021.3 and 2022.3 as well as current 6000/trunk Editors. In the older editor builds where these references are not emitted (the previous list did not contain either), this makes ValidateAssemblyReferences fail with a zero reference count, blocking the existing compatibility CI. Add the dependencies only for the Editor versions that emit them (using the relevant Unity version defines), rather than adding them to the common list.
🤖 Helpful? 👍/👎
e806f25 to
19b4fca
Compare
todi1856
left a comment
There was a problem hiding this comment.
will probably close this, since this breaks tests on 6000.0
|
The change were applied differently on master branch, as not to break 6000.0 |
This PR contains changes made to the
trunkcopy ofcom.unity.mobile.android-logcat.This usually means that breaking changes has landed in the
trunkEditor, necessitating matching changes to your package code.trunkis therefore currently running CI tests with the modified shadow package instead of your real package. You must integrate these changes into your package (while maintaining compatibility with older versions of Unity supported by your package), release a new version, and land the new version in the editor manifest before the Package RC deadline, as your package otherwise will not be compatible with the released Editor.Is this automation useful? Let us know on #devs-pets, where you can also ask any question you might have about shadow packages or this automation.
Note: The
shadow-package/com.unity.mobile.android-logcatbranch may be force-pushed by automation at any time. If you want to make changes before landing this PR, create your own branch (and PR) to avoid automation overwriting your changes:If further changes are made to the shadow package on trunk, this PR will be updated if still open, or else a new PR will be opened.