feat: implement spec-mandated webhook headers for Node.js and Python samples - #148
Merged
damaz91 merged 6 commits intoJul 28, 2026
Merged
Conversation
Only REST transport is currently supported by the Python server. Removing MCP, A2A, and Embedded transports from the discovery profile to prevent clients from attempting to use them. Closes Universal-Commerce-Protocol#133 TAG=agy CONV=4aee53ae-545a-4ca3-8b91-fee3b95e9ef7
Align Node.js version negotiation error response with the spec and Python implementation by returning HTTP 422 and a structured UcpErrorDetail. TAG=agy CONV=430e7e91-3e21-4a9d-802a-80c71390c95c
Align reference Python server error responses with error_response.json and message_error.json schemas. - Use 'messages' wrapper instead of 'errors'. - Use standard 'severity' enums (unrecoverable, requires_buyer_input). - Raise UcpError/UcpVersionError in dependencies and format in central handler. - Update integration tests to match new structure. TAG=agy CONV=66cef4ea-c19e-4693-8c23-b155a5e0cddc
…samples Implement `Webhook-Id` and `Webhook-Timestamp` headers for the `orderEvent` webhook in both Node.js and Python sample servers, as required by the UCP specification. - Generate a unique UUID for `Webhook-Id` for each event. - Generate the current Unix timestamp (seconds since epoch) for `Webhook-Timestamp`. - Include these headers in the POST request to the webhook URL. - Update integration tests to assert these headers are present and valid.
damaz91
added
the
status:needs-triage
damaz91
added
status:under-review
and removed
status:needs-triage
nicholasjameshall
approved these changes
Jul 27, 2026
carolinerg1
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement spec-mandated
Webhook-TimestampandWebhook-Idheaders fororderEventwebhook in both Node.js and Python samples.Webhook-Idfor each event.Webhook-Timestamp.Category (Required)
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
Fixes #147
Checklist
!for breaking changes).Screenshots / Logs (if applicable)