fix(rest/nodejs): retry transient webhook failures - #175
Merged
carolinerg1 merged 1 commit intoAug 12, 2026
Merged
Conversation
damaz91
approved these changes
Aug 12, 2026
carolinerg1
approved these changes
Aug 12, 2026
carolinerg1
merged commit Aug 12, 2026
04f222e
into
Universal-Commerce-Protocol:main
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
notifyWebhooktreated every resolvedfetchcall as a successful delivery, so a5xxresponse was silently dropped. Transport failures were logged once without retrying, even though the same event could be delivered safely with its original identity.Fix: retry transport errors and
5xxresponses up to three times with exponential backoff. Permanent4xxresponses are not retried, and all attempts reuse the sameWebhook-Id,Webhook-Timestamp, and serialized body.Category (Required)
Related Issues
N/A
Checklist
Screenshots / Logs (if applicable)
npm test: 123 passednpm run build: passedpre-commit run --all-files: passed