Confirm before destructive actions (revoke key, remove policy, remove member) - #1546
Open
midego1 wants to merge 2 commits into
Open
Confirm before destructive actions (revoke key, remove policy, remove member)#1546midego1 wants to merge 2 commits into
midego1 wants to merge 2 commits into
Conversation
Personal-key revoke deleted the key immediately with no confirmation, while org-key revoke (and every other destructive action) asks first. A personal key breaks any script or tool using it just the same, so add the same confirmation dialog, mirroring the org-key pattern.
Removing a tool-access policy and removing an org member each fired instantly from a dropdown click, with no confirmation — unlike every other destructive action in the UI. Add the same AlertDialog confirm the connection and artifact removals already use (state held at the page level, since the dropdown menu unmounts a nested dialog on click).
midego1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several destructive actions in the web UI fired immediately with no confirmation, while most others (remove connection, delete artifact, remove OAuth app, revoke org key, delete integration) already ask first. This makes them consistent.
Adds a confirmation to the three that deleted instantly:
api-keys.tsx) — mirrors the existing org-key revoke Dialog.policies.tsx) — instant from a dropdown click.org.tsx) — instant from a dropdown click.Policy and member removals reuse the same
AlertDialogpattern the connection/artifact removals already use, with the confirm state held at the page level (the dropdown menu unmounts a nested dialog on click). No behavior change beyond the added confirm step; each destructive button now needs a second, explicit confirmation.