Add device name for Home Assistant and OTA onStart() callback

[JanPetterMG]

Introduce a device name for display in Home Assistant and implement an onStart() callback for OTA updates, which disables UART and manages the OE pin state.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 87f9e8b5-1e63-4ee2-89be-18148b55370d

📥 Commits

Reviewing files that changed from the base of the PR and between 31ceb12 and f42e40a.

📒 Files selected for processing (1)

• src/esp/DeviceService.cpp

🚧 Files skipped from review as they are similar to previous changes (1)

• src/esp/DeviceService.cpp

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

Summary by CodeRabbit

• New Features

  • Added configurable device naming for Home Assistant, defaulting to “Bekant.”
  • Device hostname is now set automatically when connecting to Wi-Fi.
  • OTA updates now manage the device output state safely during startup.

• Bug Fixes

  • Devices enter safe mode and restore the configured output state when an OTA update begins.
  • Invalid or fragmented MQTT messages are safely ignored to prevent unintended processing.

Walkthrough

ESP32 initialization now sets the Wi-Fi hostname and uses a separate NAME value for Home Assistant discovery. OTA startup invokes a callback that enters safe mode and restores the configured output-enable state. MQTT documentation now describes ignored payloads.

Changes

ESP32 DeviceService updates

Layer / File(s)	Summary
Device identity configuration include/esp/secrets.h, src/esp/DeviceService.cpp	The ESP32 defines NAME as "Bekant", sets HOSTNAME before Wi-Fi connection, and reports NAME in Home Assistant discovery.
OTA startup and MQTT message handling include/esp/DeviceService.h, src/esp/DeviceService.cpp	DeviceService declares, registers, and implements the OTA onStart callback. The callback enters safe mode and reapplies device.oe to PIN_OE when available. The onMessage documentation states that fragmented and invalid JSON payloads are ignored.

Sequence Diagram(s)

sequenceDiagram
  participant ArduinoOTA
  participant DeviceService
  participant OutputEnableHardware
  ArduinoOTA->>DeviceService: invoke onStart()
  DeviceService->>DeviceService: invoke safeMode()
  DeviceService->>OutputEnableHardware: apply device.oe to PIN_OE

Loading

Merge Risk: 🟡 Moderate · up to f42e4

During OTA startup, builds that define PIN_OE may apply the opposite output-enable state from the configured value, causing incorrect hardware behavior while updating. The issue requires owner follow-up before this change is merge-ready.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the two main changes: the Home Assistant device name and the OTA onStart() callback.
Description check	✅ Passed	The description directly matches the changeset. It identifies the Home Assistant device name and the OTA onStart() callback, including UART and OE pin handling.
Docstring Coverage	✅ Passed	Docstring coverage is 83.33% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 3 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch feat/name-and-ota-oe

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[JanPetterMG]

@coderabbitai review

[coderabbitai]

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[JanPetterMG]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c38b1a36-5ce7-4c3e-bd9b-d71df63ef097

📥 Commits

Reviewing files that changed from the base of the PR and between c188a89 and 31ceb12.

📒 Files selected for processing (3)

• include/esp/DeviceService.h
• include/esp/secrets.h
• src/esp/DeviceService.cpp

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Review details

🔇 Additional comments (3)

include/esp/DeviceService.h (1)

54-54: LGTM!

include/esp/secrets.h (1)

45-49: LGTM!

src/esp/DeviceService.cpp (1)

52-52: LGTM!

Also applies to: 61-61, 179-179

[coderabbitai]

Note

Docstrings generation - SUCCESS
Generated docstrings for this pull request at #9