[TF2] Festivizer Support for Throwables, Sappers, and Lunchboxes#1967
Open
Piogre wants to merge 3 commits into
Open
[TF2] Festivizer Support for Throwables, Sappers, and Lunchboxes#1967Piogre wants to merge 3 commits into
Piogre wants to merge 3 commits into
Conversation
Rewrites the portion of the lunchbox code that sets the plate model for the thrown medpack for sandwiches et al, to account for the possibility of the item being festivized and set an alternate model if it is. This rewrite has the minor side-effect of always setting team-color skin for the plate model, even for weapons that don't normally have different skins per-team. This won't break anything (since the system already accounts for setting a non-existent skin and will default to skin zero) and actually solves the issue faced by authors of custom skins who find some weapons don't allow team-color skins for the dropped medpack model (the current live version breaks team-color on client-side customs for no reason).
Adds a check to the code that generates the filenames for placed/placement sapper models to see if the sapper in question is festivized, and modify the model filename accordingly if it is.
Adds a check to the code that sets the projectile models for thrown weapons to see if the weapon in question is festivized, and set an alternate model if it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Festivizers workshop submission that added Festivizer support to numerous weapons last Smissmas included models for several additional weapons that would have required extra implementation to work correctly.
This PR includes in-code support for Festivized throwable weapons, heavy lunchbox items, and spy sappers, to properly set the hard-coded models generated in-world when the weapons are used.
The full list of weapons supported with this PR:
-Mad Milk
-Mutated Milk
-Flying Guillotine
-Gas Passer
-Jarate
-Self-Aware Beauty Mark
-Sandvich
-Robo-Sandvich
-Dalokohs Bar
-Fishcake
-Buffalo Steak Sandvich
-Second Banana
-Sapper
-Ap-Sap
-Snack Attack
-Red-Tape Recorder
The model filepaths referenced in these code changes refer to models already included in the original workshop submission (and included for convenience in the tf_festives shared dropbox).
Many of these weapons do require other tweaks (to the weapon base model, item schema, etc) unrelated to the source code -- I'm working on those notes still in the new "2026 Implementation Notes" spreadsheet in the dropbox; the notes for these weapons in particular are still a work-in-progress but I will update that sheet as I go.