[ObjC] Enable removal of more memory management functions - #8524
Open
AngeloD2022 wants to merge 2 commits into
Open
[ObjC] Enable removal of more memory management functions#8524AngeloD2022 wants to merge 2 commits into
AngeloD2022 wants to merge 2 commits into
Conversation
…anagement functions.
…g the suffix of register-specific ARC functions. Also added a more robust check that verifies the origin of runtime functions on dyld shared cache binaries.
|
|
AngeloD2022
marked this pull request as ready for review
September 6, 2026 19:49
bdash
reviewed
Sep 9, 2026
| b"_objc_claimAutoreleasedReturnValue", | ||
| ]; | ||
|
|
||
| fn is_objc_rt_symbol_dscview(view: &BinaryView, symbol: &Symbol) -> bool { |
Contributor
There was a problem hiding this comment.
Can you clarify what the purpose of this function is? What is it guarding against?
|
|
||
| IGNORABLE_MEMORY_MANAGEMENT_FUNCTIONS.contains(&symbol_name) | ||
| // Normalize the name to also include register-specific functions (e.g. _objc_release_x19). | ||
| let symbol_name = util::strip_arc_reg_suffix(symbol_name); |
Contributor
There was a problem hiding this comment.
This results in incorrect handling of objc_retain_xN calls. Converting them to a no-op will result in x0 having the incorrect value.
Consider this example:
This change results in:
It should be result->_internal = _initWithCFURLResponse[1]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_objc_claimAutoreleasedReturnValueto the list of ignorable memory management functions._objc_release_x19.