DXMT: keep indexed draw base vertex signed#758
Conversation
D3D11 indexed draw calls take BaseVertexLocation as a signed INT, and Metal's baseVertex parameter is signed as well. Keep the DXMT indirect argument and winemetal command fields signed so negative base-vertex offsets are not reinterpreted as large unsigned values. Signed-off-by: Roberto Nibali <rnibali@gmail.com>
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
|
DXMT v0.80 audit update: This is already addressed in DXMT v0.80: the corresponding D3D11 indexed draw command state uses a signed So this PR is best understood as a narrow backport for VirtualBox's currently vendored DXMT snapshot. |
Summary
Keep indexed draw base vertex values signed across the DXMT/winemetal command boundary.
BaseVertexLocationis signed in D3D11, and Metal's indexed drawbaseVertexargument is signed as well. This patch changes the stored command fields fromuint32_ttoint32_tso negative base vertex values are not reinterpreted as very large unsigned offsets.Validation
git diff --checkkmk VBoxDxMton macOS/Arm using LLVM 15.0.7.Closes #754.
Signed-off-by: Roberto Nibali rnibali@gmail.com