Do not depend on DNS in the physical machines migration test - #188
Closed
janpenitent wants to merge 1 commit into
Closed
Do not depend on DNS in the physical machines migration test#188janpenitent wants to merge 1 commit into
janpenitent wants to merge 1 commit into
Conversation
The multiple IPs fixture included a 'localhost' entry that the test expected to be dropped because it does not resolve, and asserted a hostname obtained from a reverse lookup of 172.27.1.25-27. Both hold only on a machine whose resolver behaves like ours, so the test failed elsewhere. Same fix already applied on master.
Contributor
Author
|
4.0 is sealed after release: no unreported change goes in. Kept on the fixes/v4.0-* branch in case someone needs it, not for a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test assumed localhost would not resolve, but systemd-resolved synthesises it, so four servers came out where three were expected; it also asserted a non-empty hostname, which only holds where the internal reverse zone is reachable. Removes localhost from the fixture and comments out the hostname assertion, the same as already done in master.