Fix CABI definition of coop thread promotability and add tests - #696
Open
lukewagner wants to merge 1 commit into
Open
Fix CABI definition of coop thread promotability and add tests#696lukewagner wants to merge 1 commit into
lukewagner wants to merge 1 commit into
Conversation
lukewagner
force-pushed
the
fix-exclusive-bug
branch
from
August 13, 2026 18:24
c8d6b01 to
7559f7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there is some divergence between Wasmtime and the spec for which coop threads can be switched-to during a synchronous call (when one thread blocks but others can be run). Digging into it, I realized that the spec is buggy (at ensuring the stated Component Invariant #3), so this PR fixes the spec to match what Wasmtime is already correctly doing. However, testing revealed other cases where I expect it's Wasmtime that we want to change to match the (fixed) spec.
(The WASTs added here assume #687 and its WAST tests pass (regarding
thread.*-then-promote) and also probably dovetail with the WASTs merged in #691 discussed in wasmtime/#14117, so cc @alexcrichton and @dicej)