Fix readPIDFromPeer crash when child dies during launch - #1711
Open
lulicdarko wants to merge 1 commit into
Open
Conversation
When a child process (WPEWebProcess) is killed before sending its PID —
e.g. by SIGTERM during container teardown — recvmsg() returns 0 (EOF).
Previously this fell through to g_error("Unexpected short read") which
called abort(), crashing the parent.
readPIDFromPeer now returns 0 on EOF. When it returns 0, the launch
callback calls didFinishLaunchingProcess(0, IPC::Connection::Identifier{}),
which flows into WebProcessProxy::processDidTerminateOrFailedToLaunch(
ProcessTerminationReason::Crash) — the same crash notification path that
fires when a running WebProcess dies. Pages get notified, crash handling
kicks in, no abort. The socket monitor is then removed cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a child process (WPEWebProcess) is killed before sending its PID —
e.g. by SIGTERM during container teardown — recvmsg() returns 0 (EOF).
Previously this fell through to g_error("Unexpected short read") which
called abort(), crashing the parent.
readPIDFromPeer now returns 0 on EOF. When it returns 0, the launch
callback calls didFinishLaunchingProcess(0, IPC::Connection::Identifier{}),
which flows into WebProcessProxy::processDidTerminateOrFailedToLaunch(
ProcessTerminationReason::Crash) — the same crash notification path that
fires when a running WebProcess dies. Pages get notified, crash handling
kicks in, no abort. The socket monitor is then removed cleanly.
(IPC::readPIDFromPeer):
(WebKit::ProcessLauncher::launchProcess):
c5a0bc4