Conversation
Avoids materializing classList for every class lookup during matching, and fixes [class=""] matching elements without a class attribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When matching selectors,
getAttributeValuereadclassthroughelement.classList.value, which creates theclassListfor every element it checks. This change reads theclassattribute node directly:Behaviour change (fix)
[class=""]used to match elements that have noclassattribute, becauseclassList.valueis''for them. Browsers only match elements that have an emptyclassattribute. Now linkedom does too. I added a test totest/html/document.js. It covers HTML and SVG elements,removeAttribute,classNameandclassList.Benchmark
2000 elements, 50 class-heavy selector groups,
querySelectorAllrun 500 times (Node, 3 runs each):