Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions .github/workflows/pre-commit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,7 @@ jobs:
- name: detect method
id: detect
run: |
if test -f requirements-lint.txt ; then
echo "method=requirements" >> "$GITHUB_OUTPUT"
elif test -f pyproject.toml && grep -q dependency-groups pyproject.toml ; then
if test -f pyproject.toml ; then
echo "method=pep735" >> "$GITHUB_OUTPUT"
else
echo "method=uvx" >> "$GITHUB_OUTPUT"
Comment on lines +34 to 37

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep honoring the pinned lint requirements

In this repository, requirements-lint.txt pins prek==0.4.13 and there is no pyproject.toml, so this detector now routes every CI run to uvx prek and silently bypasses the only declared lint dependency. The installed uvx --help documents --with-requirements as the option for installing packages from a requirements file, but the workflow does not use it; consequently CI resolves an unconstrained prek version while Renovate continues updating a file that no longer affects the checks. Retain the requirements-based dispatch or otherwise preserve the declared pin.

Useful? React with 👍 / 👎.

Expand All @@ -56,16 +54,6 @@ jobs:
RUFF_OUTPUT_FORMAT: github
REUSE_OUTPUT_FORMAT: github
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: pre-commit (requirements)
if: steps.detect.outputs.method == 'requirements'
run: |
uv pip install --system -r requirements-lint.txt
prek run --all-files --show-diff-on-failure
prek cache gc
env:
RUFF_OUTPUT_FORMAT: github
REUSE_OUTPUT_FORMAT: github
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: diff
run: git diff
if: always()
Expand Down
24 changes: 0 additions & 24 deletions .github/workflows/pull_requests.yaml

This file was deleted.

Loading