Skip to content

test: add unit tests for get_the_terms() object cache handling - #13226

Open
SainathPoojary wants to merge 1 commit into
WordPress:trunkfrom
SainathPoojary:test/49799
Open

test: add unit tests for get_the_terms() object cache handling#13226
SainathPoojary wants to merge 1 commit into
WordPress:trunkfrom
SainathPoojary:test/49799

Conversation

@SainathPoojary

Copy link
Copy Markdown

The ticket reports that get_the_terms() returns false instead of the correct terms when get_object_term_cache() returns an empty array.

Investigation shows the false === $terms check is correct. It distinguishes a cache miss from a valid "no terms" state ([]). When terms are assigned, wp_set_object_terms() properly clears the cache so get_the_terms() will query the database on the next call. The reported bug is likely a test environment configuration issue.

As requested, this PR adds unit tests to verify the expected cache behavior:

  1. Cache primed with [] before terms assigned → terms assigned → returns correct terms.
  2. Cache primed with [] for a post with no terms → returns false without a DB query.
  3. Cache primed after term assignment → returns correct terms from cache.

All tests pass on current trunk with no source change needed.

Trac ticket: https://core.trac.wordpress.org/ticket/49799

Use of AI Tools

AI assistance: Yes
Tool(s): Github Copilot
Used for: Investigating the cache flow and generating initial unit tests. Implementation and testing were reviewed and edited by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sainathpoojary.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant