Plugin Directory: Sync plugin status to the update API during a release cooldown

[obenland]

Summary

Fixes a gap in the release cooldown: while a new version is being held back, API_Update_Updater::update_single_plugin() defers the whole update_source write — so a status change made during those hours never reaches the update API. Closing a plugin mid-cooldown keeps offering it to sites; reopening one keeps it withdrawn; disabling one never records its closure meta.

The fix

Only the version bump waits for the cooldown. A status change made mid-cooldown syncs the existing row immediately — availability, closure meta (closed_at/closed_reason), and last_updated — via a new update_row_availability(), while the row keeps serving the previous release's data, so version-specific columns (version, stable_tag, release_time, rollout) never describe the held version. A plugin whose first-ever release is in cooldown has no row and gets none until the cooldown expires.

Shared logic is extracted rather than duplicated: get_close_meta() (closure fields, used by the full write and the sync) and clear_plugin_caches() (the update-check/info-API cache purge, which every row write must be followed by).

Note that cron_trigger()'s out-of-date query still re-selects an in-cooldown plugin every hourly run — the row's version/stable_tag differ from the post's by construction until the cooldown expires, and that mismatch can't be resolved without releasing the version. Each re-pass is an idempotent no-op: the status sync re-writes values the row already holds.

Review fixes (second commit)

• The pre-sync guard tested the truthiness of the row's version string, so a stored '0' (or '') read as "no row" and skipped the status sync. It now tests row existence, and the row's version and meta are fetched in one query, dropping update_row_availability()'s redundant second SELECT.
• clear_plugin_caches() now reuses Plugins_Info_API::flush_plugin_information_cache() instead of hand-building plugin_information:{slug}:{locale} keys from raw GP_Locales casing — the API stores those keys lowercased, so the hand-built purge was a no-op for every mixed-case locale (de_DE, pt_BR, …).
• The availability predicate is extracted into is_available() instead of being duplicated (with strictness drift) across both writers.

Testing

New tests/Update_Source_Cooldown_Test.php: the version bump stays deferred; a closure withdraws the row immediately (still on the served version); a disable records closure meta with the row still available; a reopen restores the row; a first release in cooldown creates no row.

The stub update_source/svn_access tables and the PLUGINS_TABLE_PREFIX constant come from the wp-env test environment: the after-start script imports the shared SQL file on every start (locally and in CI), and the constant is written into wp-tests-config.php. The WP test installer drops only core tables, so the stub tables persist across runs, and the test clears leftover rows per plugin.

Notes

This is split out of #777, which builds its scan-driven release block on the same "hold the version, sync the status" write path. #777 will be rebased onto this once it lands.

🤖 Generated with Claude Code

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props obenland.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[Copilot]

Pull request overview

This PR fixes a release-cooldown edge case in the Plugin Directory’s Update API sync: while a new version is held back, plugin status/availability changes (close/disable/reopen) are now synced immediately to the existing update_source row, instead of being deferred along with the version bump.

Changes:

• Update cooldown handling so only the version bump is deferred; status-dependent fields (availability + closure meta) sync immediately via a new update_row_availability().
• Extract shared logic into helpers (get_close_meta(), clear_plugin_caches()) so both full writes and availability-only syncs stay consistent.
• Add a PHPUnit test suite for cooldown behavior, and enhance the test bootstrap to define PLUGINS_TABLE_PREFIX and create required stub tables.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-api-update-updater.php	Splits cooldown behavior into deferred version updates vs immediate availability/meta sync; extracts shared helpers.
wordpress.org/public_html/wp-content/plugins/plugin-directory/tests/bootstrap.php	Defines PLUGINS_TABLE_PREFIX and creates stub external tables for tests using the shared SQL file.
wordpress.org/public_html/wp-content/plugins/plugin-directory/tests/Update_Source_Cooldown_Test.php	Adds coverage for cooldown scenarios (deferred version bump, close/disable/reopen sync, and no-row-first-release behavior).

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (2)

wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-api-update-updater.php:96

• $existing_row can be null when there is no update_source row; using $existing_row->version ?? '' still attempts the property read and can emit a PHP warning. Use the nullsafe operator (or an explicit conditional) to avoid warnings in the common “no row yet” case.

		$existing_version = (string) ( $existing_row->version ?? '' );

wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-api-update-updater.php:125

• During a release cooldown, cron_trigger() will keep selecting the plugin (version mismatch is expected), so this call path runs every hour. Calling update_row_availability() unconditionally means an UPDATE query is executed on every pass even when availability/close meta/last_updated haven’t changed. Consider short-circuiting before the UPDATE when the computed availability + close meta match the current row, to reduce steady-state DB write load during long cooldowns.

				}

				return true;