Plugin Directory: Pin release resolution on legacy data shapes. - #809
Closed
obenland wants to merge 1 commit into
Closed
Plugin Directory: Pin release resolution on legacy data shapes.#809obenland wants to merge 1 commit into
obenland wants to merge 1 commit into
Conversation
The cron path feeds every plugin's historical data through the new resolution, so the shapes tests can't invent from clean fixtures are pinned explicitly: empty version/stable_tag metas, releases prefilled from the tags meta, elapsed cooldown windows on old releases, integer- typed tags from before the string cast, and tag names that aren't the version string. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to [15077] / #807: characterization tests for the data shapes the cron path feeds through the new release resolution, which clean fixtures don't naturally produce.
cron_trigger()selects any plugin whoseupdate_sourcerow looks out of sync, so over time every plugin in the directory — including ones untouched for a decade — flows throughget_current_release(). These tests pin the legacy shapes that resolution must handle:versionandstable_tagmetas resolve no release, and the row write neither errors nor defers.releasesmeta gets it prefilled from thetagsmeta, resolves by stable tag, and its old release doesn't defer the row.add_release()) resolve, and the strict merge lands on them instead of duplicating.v2.0) resolve by the stable tag; the old lookup couldn't find these at all.Test-only; no production code changes.
🤖 Generated with Claude Code