fix(chat): log diagnostics when tool loop returns an empty answer - #7
Open
Zeptiny wants to merge 1 commit into
Open
fix(chat): log diagnostics when tool loop returns an empty answer#7Zeptiny wants to merge 1 commit into
Zeptiny wants to merge 1 commit into
Conversation
The 'Não foi possível gerar uma resposta.' fallback fired silently with no log output, making empty LLM responses (e.g. reasoning models burning the whole max_tokens budget, finish_reason=length, content_filter) impossible to diagnose. Now the fallback logs a WARNING with model, rounds used, finish_reason history and token usage; each loop round logs finish_reason and usage at DEBUG; malformed tool-call arguments and exhausted max_rounds are logged too. Whitespace-only content now also triggers the fallback instead of sending a blank embed.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'Não foi possível gerar uma resposta.' fallback fired silently with no log output, making empty LLM responses (e.g. reasoning models burning the whole max_tokens budget, finish_reason=length, content_filter) impossible to diagnose. Now the fallback logs a WARNING with model, rounds used, finish_reason history and token usage; each loop round logs finish_reason and usage at DEBUG; malformed tool-call arguments and exhausted max_rounds are logged too. Whitespace-only content now also triggers the fallback instead of sending a blank embed.