fix: persist early producer failure as FAILED with originating message#1106
fix: persist early producer failure as FAILED with originating message#1106AXEG0 wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request ensures that early producer failures are persisted directly as failed tasks and that originating messages are preserved in the task history. It also adds corresponding unit tests. Feedback includes improving Protobuf message comparison by using message_id instead of direct equality, and directly assigning the task status state instead of using CopyFrom to avoid clearing other status fields.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/server/agent_execution/active_task.py | 95.92% | 95.99% | 🟢 +0.07% |
| Total | 92.99% | 92.99% | ⚪️ 0.00% |
Generated by coverage-comment.yml
Fixes #1067
Summary
Tests