feat: Add instant navigation with Next.js 13.3 - #749
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e50a16d932
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <React.Suspense fallback={<PasswordResetContentSkeleton />}> | ||
| <PasswordResetContent searchParams={searchParams} /> | ||
| </React.Suspense> |
There was a problem hiding this comment.
When an installation has no email adapter, PasswordResetContent calls notFound() only after this Suspense boundary has allowed the card skeleton to stream. Once the fallback starts the response as 200, Next.js cannot return the real 404 that this route previously produced; crawlers, caches, and monitoring therefore see a successful reset-password page even though the final UI becomes not-found. Resolve the email capability before streaming, or mark this route non-instant so the status can be decided first.
Useful? React with 👍 / 👎.
| cacheComponents: true, | ||
| partialPrefetching: true, |
There was a problem hiding this comment.
Enabling Cache Components and partial prefetching globally introduces a new contract for every generated application, including when route data must be wrapped in Suspense and when instant = false is required to preserve status codes. A repo-wide search for instant finds only implementation comments and no user-facing documentation, so application and plugin authors have no guidance for safely adding routes under this configuration. Add a concise guide and document the opt-out before enabling it by default.
AGENTS.md reference: AGENTS.md:L53-L55
Useful? React with 👍 / 👎.
| <Skeleton className="h-8 w-[4.5rem]" /> | ||
|
|
||
| <div className="flex items-center space-x-2"> |
There was a problem hiding this comment.
The new pagination skeleton uses both the arbitrary w-[4.5rem] width and space-x-2; use a spacing-scale width and gap-2 instead. These classes directly violate the repository's requirements to avoid arbitrary spacing values and all space-* utilities.
AGENTS.md reference: AGENTS.md:L46-L47
Useful? React with 👍 / 👎.
1 participant
Improving Documentation
pnpm lint:fixto fix formatting issues before opening the PR.Description
What?
Why?