Support absolute paths in node-version-file - #1633
Open
v-mahabaleshwars wants to merge 2 commits into
Open
v-mahabaleshwars wants to merge 2 commits into
v-mahabaleshwars wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
All reviewed changes are covered by documentation, tests, and the updated bundle.
Review effort: Lite
Findings: None
What changed in this PR
Updates node-version-file handling to support absolute paths while preserving workspace-relative resolution.
Changes:
- Uses
path.resolvein source and bundled output. - Documents path resolution behavior.
- Adds tests for relative and absolute paths.
| File | Summary |
|---|---|
src/main.ts |
Resolves version-file paths correctly. |
docs/advanced-usage.md |
Documents path resolution behavior. |
dist/setup/index.js |
Updates the packaged action bundle. |
__tests__/main.test.ts |
Covers relative and absolute paths. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
v-priya-kinthali
approved these changes
Sep 21, 2026
v-gowridurgad
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Use
path.resolveinstead ofpath.joinso an absolutenode-version-fileinput is used as-is. Relative paths still resolve againstGITHUB_WORKSPACE.Related issue:
#852
Check list: