rp2040/rp2350: Support multicast TTL socket option - #11174
Draft
Daniiiil1 wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Daniil Mordanov <mordanovdania@gmail.com>
Member
|
@todbot want to test this? The issue from jepler says it is needed for your MicroOSC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9938.
The Raspberry Pi port uses lwIP's raw API rather than its socket API, so it cannot delegate this option to
lwip_setsockopt()as the Espressif port does. HandleIPPROTO_IP/IP_MULTICAST_TTLfor UDP sockets by updating the UDP PCB's multicast TTL directly.The implementation also:
EOPNOTSUPPfor non-datagram sockets;EINVALfor a closed UDP PCB or an empty option value;IP_MULTICAST_TTLrepresentation.Testing:
pre-commit run --files ports/raspberrypi/common-hal/socketpool/Socket.cgmake -C ports/raspberrypi BOARD=raspberry_pi_pico_w -j4gmake -C ports/raspberrypi BOARD=raspberry_pi_pico2_w -j4udp_pcb.mcast_ttlBoth builds produced
firmware.uf2. I do not have a Pico W/Pico 2 W connected, so I have not performed an on-device multicast packet capture.