audio Flanger FX implementation - #11175
Open
FoamyGuy wants to merge 3 commits into
Open
Conversation
tannewt
approved these changes
Aug 4, 2026
tannewt
left a comment
tannewt
left a comment
Member
There was a problem hiding this comment.
Looks great to me! Please always consider a new module for new effects. That way boards won't need the existing ones disabled for the new one to fit.
relic-se
suggested changes
Aug 4, 2026
relic-se
left a comment
relic-se
left a comment
There was a problem hiding this comment.
Looking good so far. I'd like to see a getter to obtain the current state of the internal triangle lfo (from 0.0 to 1.0). Would also be cool to be able to change the waveform, but then we're getting into synthio.BlockInput territory in which some of this functionality could already be achieved with audiodelays.Echo.
| // Store if we have more data in the sample to retrieve | ||
| self->more_data = result == GET_BUFFER_MORE_DATA; | ||
|
|
||
| return; |
|
|
||
| void common_hal_audiodelays_flanger_stop(audiodelays_flanger_obj_t *self) { | ||
| self->sample = NULL; | ||
| return; |
| //| spectrum, and the ``feedback`` path routes the delayed signal back into the delay line | ||
| //| to sharpen those notches into resonant peaks. | ||
| //| | ||
| //| The delay is swept upwards from ``delay_ms`` towards ``max_delay_ms``:: |
There was a problem hiding this comment.
I think the naming min_delay_ms would make more sense to me following this logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new effect class Flanger to
audiodelaysimplementing flanging effectTesting was performed on Metro RP2350