docs(release): note the 8.0.0 release candidate - #1238
Merged
Merged
Conversation
bokelley
marked this pull request as ready for review
September 28, 2026 12:24
![aao-secretariat[bot]](https://avatars.githubusercontent.com/u/221690821?s=60&v=4){kind=small}
There was a problem hiding this comment.
Ladon verdict: Approve
Approve
Single-file, prose-only update to docs/reporting-release-notes.md (+5/-5) replacing stale prerelease-pending wording with an 8.0.0 release-candidate note. Reviewer verified the schema-bundle claim (ADCP_VERSION=3.2.0-rc.7; 3.0/3.1/3.2.0-rc.7 caches present), correct docs(release): prefix with no public-surface or semver change, and internal consistency with the preserved acceptance/interop caveat.
No blocking findings. No medium findings. Not high-risk; gated_paths false; no author-team gate. Rows 1–8 do not fire — falls through to row 9.
Note: review_decision is REVIEW_REQUIRED, but since gated_paths is false, row 2 does not apply and does not block approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace stale prerelease-pending wording with the 8.0.0rc1 release note: the SDK API is frozen for 8.0.0, final follows AdCP 3.2.0 final, and this candidate bundles 3.0, 3.1, and 3.2.0-rc.7 schemas.
The squash commit for this PR must carry
Release-As: 8.0.0-rc.1in its commit body. That tells the pinned Release Please v5 to start the rc series from the beta.18 manifest. The superseded beta.19 release PR #1237 is closed.Validation:
make lint,make typecheck-allagainst this worktree's source, release configuration and normalizer tests (8 passed),git diff --check, commit hooks, andmake test(12,110 passed; 2,397 skipped; 9 deselected; 1 expected failure; 81.54% coverage). CI is in progress.