-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(listbox): support disabling entire listboxes #10619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dvd233
wants to merge
3
commits into
adobe:main
Choose a base branch
from
dvd233:codex/fix/listbox-disabled-state-5837
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,6 +36,8 @@ import {useLabel} from '../label/useLabel'; | |
| import {useSelectableList} from '../selection/useSelectableList'; | ||
|
|
||
| export interface ListBoxProps<T> extends CollectionBase<T>, MultipleSelection, FocusEvents { | ||
| /** Whether the listbox is disabled. */ | ||
| isDisabled?: boolean; | ||
| /** Whether to auto focus the listbox or an option. */ | ||
| autoFocus?: boolean | FocusStrategy; | ||
| /** Whether focus should wrap around when the end/start is reached. */ | ||
|
|
@@ -150,7 +152,7 @@ export function useListBox<T>( | |
| ref, | ||
| selectionManager: state.selectionManager, | ||
| collection: state.collection, | ||
| disabledKeys: state.disabledKeys, | ||
| disabledKeys: props.isDisabled ? new Set(state.collection.getKeys()) : state.disabledKeys, | ||
| linkBehavior | ||
| }); | ||
|
|
||
|
|
@@ -164,6 +166,7 @@ export function useListBox<T>( | |
| let id = useId(props.id); | ||
| listData.set(state, { | ||
| id, | ||
| isDisabled: props.isDisabled, | ||
| shouldUseVirtualFocus: props.shouldUseVirtualFocus, | ||
| shouldSelectOnPressUp: props.shouldSelectOnPressUp, | ||
| shouldFocusOnHover: props.shouldFocusOnHover, | ||
|
|
@@ -194,6 +197,7 @@ export function useListBox<T>( | |
| : {}, | ||
| { | ||
| role: 'listbox', | ||
| 'aria-disabled': props.isDisabled || undefined, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think |
||
| 'aria-orientation': orientation, | ||
| ...mergeProps(fieldProps, listProps) | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't love this extra full collection iteration, at the very least we should memo it.
otherwise, we'll want to consider expanding the api to "all" or a new isDisabled prop meaning the entire selectable list. That may end up adding the new partial behaviour to every selectable list though, so would need to be careful with that.