Skip to content

fix: keep S2 toast controls spaced from the expanded list while scrol… #10621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zakkaus wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −17
Open

fix: keep S2 toast controls spaced from the expanded list while scrol… #10621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 8 additions & 17 deletions packages/@react-spectrum/s2/src/Toast.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,14 @@ const toastRegion = style({
},
boxSizing: 'border-box',
maxHeight: 'full',
borderRadius: 'lg'
borderRadius: 'lg',
// Spacing lives here rather than in the list so it does not scroll away with the toasts.
paddingY: {
isExpanded: 8
},
gap: {
isExpanded: 8
}
});

const toastList = style({
Expand All @@ -227,22 +234,6 @@ const toastList = style({
// Add padding when expanded to account for focus ring.
isExpanded: 8
},
paddingBottom: {
isExpanded: {
placement: {
top: 8,
bottom: 16

@snowystinger snowystinger Sep 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened to the 16, now they're both only 8

@Zakkaus Zakkaus Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

圖片 圖片

Still 16 total on the viewport side: 8 on the list for the focus ring, 8 moved to the region so it stays outside the scroll container. The side next to the buttons goes from 8 to 16 for the same reason, and the buttons now keep 8 from the viewport edge.

}
}
},
paddingTop: {
isExpanded: {
placement: {
top: 16,
bottom: 8
}
}
},
margin: 0,
marginX: {
default: 0,
Expand Down
Loading