Skip to content

fix(onboard-status): show no-scrape-data scraping state as neutral, not failed #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tkotthakota-adobe merged 1 commit into from
Aug 5, 2026
+6 −1
Merged

fix(onboard-status): show no-scrape-data scraping state as neutral, not failed #343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/tasks/opportunity-status-processor/handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,11 +606,16 @@ export async function runOpportunityStatusProcessor(message, context) {
const seoImportStatus = seoImportAvailable ? ':white_check_mark:' : ':x:';
const gscStatus = gscConfigured ? ':white_check_mark:' : ':x:';
// Tri-state scraping: hourglass while URLs are still being scraped, so an
// in-progress snapshot is not mislabelled as a failure.
// in-progress snapshot is not mislabelled as a failure. 'unknown' (no scrape data
// yet) shows a neutral info icon — not ❌ (which would falsely read as failed) and
// not ⏳ (which would overclaim active progress). Only a genuinely terminal-failed
// scrape (0 completed, 0 pending, >0 failed) shows ❌.
const scrapingStatusKey = deriveScrapingStatus(scrapingStats);
const scrapingEmoji = {
available: ':white_check_mark:',
in_progress: ':hourglass_flowing_sand:',
unknown: ':information_source:',
failed: ':x:',
}[scrapingStatusKey] || ':x:';
const scrapingStatus = scrapingEmoji;

Expand Down
Loading