@W-23748894 fix(webhooks): align event name with method pill in URL area - #102
Merged
Merged
Conversation
The webhook event name renders inside .url-server-value, whose 8px top margin exists to separate it from a preceding "Channel" line in the non-HTTP case. For a webhook there is no Channel line, so .url-server-value is the sole child and the margin just pushes the event name out of line with the method pill. Zero the margin only when .url-server-value is the first child; the non-HTTP "Channel + Server" stack is unaffected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Aligns the webhook event name with the method pill in the operation URL area.
Why
For OAS 3.1/3.2 webhooks,
api-urlrenders the event name inside.url-server-valueinstead of a URL/server. That class carriesmargin-top: 8px, which exists to separate it from a preceding.url-channel-value("Channel") line in the non-HTTP (AsyncAPI/protocol) case, where.url-valuestacks two blocks. A webhook has no "Channel" line, so.url-server-valueis the sole child and the 8px margin just pushes the event name out of vertical alignment with the method pill.Fix
Zero the top margin only when
.url-server-valueis the first child of.url-value:.url-server-valueis the sole/first child → margin removed → event name aligns with the method pill..url-server-valuefollows.url-channel-value→ not:first-child→ keeps the 8px separation..url-server-valueas a first child → unaffected.Version
Bumps to
5.2.34.Refs