Update Client.Game.UI.Achievement - #1890
Merged
Merged
Conversation
Contributor
Author
|
actions/checkout@v4 now blocks checking out fork PR code from pull_request_target, and both workflows use that pattern. see https://github.com/actions/checkout/releases/tag/v4.4.0 and https://github.blog/changelog/2026-06-18-safer-pull_request_target-defaults-for-github-actions-checkout/ |
wolfcomp
requested changes
Jul 21, 2026
wolfcomp
left a comment
wolfcomp
left a comment
Collaborator
There was a problem hiding this comment.
Rebase against latest main.
github-actions
Bot
added
breaking change
Contributor
Author
|
done |
wolfcomp
added
the
outdated
Haselnussbomber
removed
the
outdated
wolfcomp
requested changes
Aug 6, 2026
wolfcomp
left a comment
wolfcomp
left a comment
Collaborator
There was a problem hiding this comment.
A few things I have noted down.
Co-authored-by: wolfcomp <4028289+wolfcomp@users.noreply.github.com>
Co-authored-by: wolfcomp <4028289+wolfcomp@users.noreply.github.com>
Co-authored-by: wolfcomp <4028289+wolfcomp@users.noreply.github.com>
Contributor
Author
|
thanks for reviews, all resloved now |
wolfcomp
requested changes
Aug 6, 2026
wolfcomp
left a comment
wolfcomp
left a comment
Collaborator
There was a problem hiding this comment.
Some more stuff to be fixed up.
Contributor
Author
|
Thanks for such detailed reviews again. All resolved now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.