fix: use colon separator in Slice 2 timer - #28
Conversation
Context for reviewersThis is the third PR in the sequence. Its parent already contains the email-verification synchronization and auth-cache isolation work from PRs 27 and 29. The incremental product change here is the Slice 2 timer separator correction. The user-visible issueThe clock component previously transformed the first ordinary colon with: .replace(':', '꞉')
The old expression also produced mixed separators in long stopwatch values. The first separator came from the fallback glyph while the second remained an ordinary colon. What changesThe component now renders the value returned by its existing clock/stopwatch/pomodoro expression directly. The The following behavior stays unchanged:
This makes the change presentation-only. For example:
The time values remain the same after normalizing the old modifier glyph to an ordinary colon. Review guidanceThe focused timer test protects the source-level regression by checking that:
The Lachesis test glob also keeps the profile-query and auth-cache tests from PRs 27 and 29 in the same local run: npm test --workspace=@lepse/lachesisA useful manual check is to view the normal clock, a running stopwatch below and above one hour, and a pomodoro timer. The separator should be the same ordinary The test remains a local/manual check because the current Lachesis release workflow builds the app but does not run the frontend test suite. Sequence and review boundaryPR 28 includes PR 27 and PR 29 by design. Reviewers can isolate this PR's intended product delta by comparing the auth-cache head with this head: the timer component and its focused test are the only new product paths. The intended landing order is:
The locale formatting behavior in |
Summary
This is PR 3 of a three-PR sequence. Its head is commit
fb0cace2c457d38fa4cfccef0b2cbf74f1ffb6b1and includes PRs 1 and 2 by design.Merge the email-verification and auth-cache PRs first. After those merges, this PR's remaining change is the timer separator correction.