Skip to content

make did-pkh fixtures Windows-safe - #146

Open
omerbek wants to merge 1 commit into
agentcommercekit:mainfrom
omerbek:agent/windows-safe-did-pkh-fixtures-145
Open

make did-pkh fixtures Windows-safe#146
omerbek wants to merge 1 commit into
agentcommercekit:mainfrom
omerbek:agent/windows-safe-did-pkh-fixtures-145

Conversation

@omerbek

@omerbek omerbek commented Aug 12, 2026

Copy link
Copy Markdown

Closes #145.

What changed

  • Renamed the did-pkh JSON test fixtures so their filenames do not contain : characters.
  • Updated the pkh-did-resolver fixture imports to point at the renamed files.

The fixture contents and DID strings used by the tests are unchanged.

Why

Windows does not allow : in filenames. The previous fixture names prevented a normal checkout of the repository on Windows.

Testing

  • Verified the affected fixture paths no longer contain : in this branch.
  • Could not run the package tests locally from this Windows checkout because the upstream branch itself cannot be checked out cleanly before this fix.

Summary by CodeRabbit

  • Tests
    • Updated DID test references to use the renamed fixture paths.
    • Added coverage fixtures for Ethereum mainnet, an additional Ethereum network, and Solana DID documents.
    • Included verification, authentication, assertion, delegation, and invocation metadata in the new fixtures.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f4db00cb-54dc-41b9-92cf-363028036569

📥 Commits

Reviewing files that changed from the base of the PR and between 0b8fdaa and 712aa0a.

📒 Files selected for processing (4)
  • packages/did/src/did-resolvers/pkh-did-resolver.test.ts
  • packages/did/test-fixtures/did-pkh/eip155-1-0xb9c5714089478a327f09197987f16f9e5d936e8a.json
  • packages/did/test-fixtures/did-pkh/eip155-84532-0xa0ae58da58dfa46fa55c3b86545e7065f90ff011.json
  • packages/did/test-fixtures/did-pkh/solana-4sGjMW1sUnHzSxGspuhpqLDx6wiyjNtZ-CKg5d12Jhpej1JqtmxLJgaFqqeYjxgPqToJ4LBdvG9Ev.json

Walkthrough

The change adds DID PKH fixtures with Windows-safe filenames and updates resolver test imports to match the renamed files. The fixture DID documents retain their identifiers and verification relationships.

Changes

DID PKH fixture updates

Layer / File(s) Summary
Add DID document fixtures
packages/did/test-fixtures/did-pkh/*
Added Ethereum and Solana DID document fixtures with verification methods and authentication, assertion, delegation, and invocation relationships.
Update resolver test imports
packages/did/src/did-resolvers/pkh-did-resolver.test.ts
Updated fixture imports for Ethereum, Base Sepolia, and Solana to use the renamed paths.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: making did-pkh fixtures compatible with Windows.
Linked Issues check ✅ Passed The PR removes colons from did-pkh fixture filenames and updates imports without changing DID semantics, satisfying issue #145.
Out of Scope Changes check ✅ Passed All changes support the Windows checkout fix and no unrelated code or behavior changes are identified.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows checkout fails on did-pkh fixture filenames

1 participant