fix(core): synchronize shared JSON schema generation - #2857
Open
mikemikimike wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JsonSchemaUtilsshares one victoolsSchemaGeneratorinstance across all structured-output calls. The generator and Jackson introspection caches are not thread-safe, so overlapping calls can fail withConcurrentModificationException.This change serializes schema generation for both class and generic type entry points with a dedicated lock. The public API and schema conversion behavior remain unchanged.
Testing
mvn -pl agentscope-core -Dtest=JsonSchemaUtilsTest test(8 tests passed)mvn -pl agentscope-core spotless:applygit diff --checkCloses #2795.