Conversation
c-cube
force-pushed
the
sc/more-control-over-httpev-compression
branch
from
September 15, 2026 15:34
b45becf to
7a38096
Compare
c-cube
marked this pull request as ready for review
September 15, 2026 16:11
rr0gi
approved these changes
Sep 22, 2026
Comment on lines
+429
to
+435
| let has_header_value name value hdrs = | ||
| List.exists (fun (k,v) -> Stre.iequal k name && Stre.iequal (String.strip v) value) hdrs | ||
|
|
||
| let is_application_gzip hdrs = | ||
| List.exists begin fun (k,v) -> | ||
| Stre.iequal k "content-type" && Stre.iequal (String.strip @@ Stre.before v ";") "application/gzip" | ||
| end hdrs |
Contributor
There was a problem hiding this comment.
there is find_header helper, lets use that
| in | ||
| (* possibly apply encoding *) | ||
| let (hdrs,body) = | ||
| (* TODO do not apply encoding to application/gzip *) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.