Pin Falco and Go base image versions - #2
Merged
Merged
Conversation
The image built both halves from floating references: `golang:latest` and `falco@latest`. A release on either side could change what the action does with no change in this repository, so pin both. Falco is pinned to v1.21.1. Upstream tags v2.x, but its go.mod still declares the unsuffixed module path `github.com/ysugimoto/falco`, so `go install` cannot resolve those tags at all — `@latest` was already resolving to v1.21.1 and a `@v2.x.y` pin fails outright. The pin therefore freezes what was being installed rather than changing it. The base image is pinned to golang:1.26.6, which satisfies the `go 1.24.3` that Falco v1.21.1 requires. 🤖 Assisted-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image built both halves from floating references:
golang:latestandfalco@latest. A release on either side could change what the action does with no change in this repository, so both are now pinned.Falco to
v1.21.1. Upstream tagsv2.x, but itsgo.modstill declares the unsuffixed module pathgithub.com/ysugimoto/falco, sogo installcannot resolve those tags at all:github.com/ysugimoto/falco/@latestreturnsv1.21.1github.com/ysugimoto/falco/@v/v2.3.0.inforeturns 404github.com/ysugimoto/falco/v2/@latestreturnsgo.mod has non-.../v2 module pathSo
@latestwas already resolving tov1.21.1, and a@v2.x.ypin would fail the build outright. This pin freezes what was being installed rather than changing it.Base image to
golang:1.26.6, which satisfies thego 1.24.3that Falcov1.21.1requires.Version label bumped to
1.1.1-- a patch, since nothing consumer-visible changes.Bumping either pin later means checking that the base image stays at or above Falco's required Go version, and whether upstream has adopted a
/v2module path.🤖 Assisted-by: Claude noreply@anthropic.com