Conversation
The 'emoji key' link the CLI writes into every README's contributors section points at https://allcontributors.org/docs/en/emoji-key, which now returns 404. The page moved to https://allcontributors.org/en/reference/emoji-key/. Update the source string in src/init/init-content.js, the README, and the matching init/add snapshots so newly initialised projects link to the live page. Byte-for-byte identical otherwise; full vitest suite passes (114 tests).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "emoji key" link that the CLI writes into the contributors section of every README points to:
That URL now returns 404 — the docs site was reorganised and the page moved to:
You can confirm: the old path returns 404 while the new one returns 200. Because this string is emitted by
all-contributors init, the dead link has propagated into a very large number of downstream project READMEs.Fix
Point the generated link at the live page. Changed:
src/init/init-content.js— the source string used for new projectsREADME.md— this repo's own contributors sectionsrc/init/__tests__/__snapshots__/init-content.js.snapandadd-contributors-list.js.snap— the snapshots that assert the generated contentNo behavioural change other than the corrected URL.
Verification
…/docs/en/emoji-key→ 404; new URL…/en/reference/emoji-key/→ 200.vitest run→ 15 files, 114 tests passed (snapshots updated to match the corrected source).eslint --fix+prettier --write(lint-staged pre-commit) pass.