fix: parse markdown custom type links into href values - #539
Open
theworker02 wants to merge 1 commit into
Open
theworker02 wants to merge 1 commit into
theworker02 wants to merge 1 commit into
Conversation
Custom contribution types documented as markdown badges (`[symbol](url)`) were injected wholesale into the HTML `href`. Extract the URL (and optional label) so anchors render correctly. Fixes all-contributors#520. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Review from Matheus Breguêz (@matbrgz): Nice catch on issue #520, @theworker02! Extracting the target URL from the markdown syntax |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When custom contribution
types.*.linkvalues use the documented markdown form ([<%= symbol %>](https://…)), the rendered badge previously put that whole string intohref.This extracts the markdown URL into
href(and the bracket text into the anchor label), while keeping plain URL templates working as before.Test plan
npx vitest run src/generate/__tests__/format-contribution-type.jstypes[key].linkis injected as-is into HTMLAnchorElement's href attribute #520 markdownlinkconfigFixes #520