fix(ui): make the advanced prompt editor scrollable#645
fix(ui): make the advanced prompt editor scrollable#645floze-the-genius wants to merge 2 commits into
Conversation
|
The PR Policy check is blocking this PR because required template information is missing. Please update the PR description with:
Visual files detected:
Screenshots or video are required for UI, UX, settings, onboarding, overlay, menu bar, or visual behavior changes. If this PR has no visual changes, check the no-visual-change box in the template. If this remains incomplete for 48 hours after opening, the PR may be closed. |
Greptile SummaryThis PR makes the Advanced Prompt editor sheet scrollable by wrapping the editable content in a SwiftUI
|
Description
Makes the Advanced Prompt editor usable when its content is taller than the available macOS window.
The sheet now has a height cap and two explicit regions:
Keeping the actions outside the scroll view means Save and Cancel remain reachable even when the embedded AppKit prompt editor consumes its own scroll gestures.
Type of Change
Related Issue or Discussion
Closes #633.
Testing
swiftlint --strict --config .swiftlint.yml Sourcesswiftformat --config .swiftformat Sources/Fluid/UI/AISettingsView+AdvancedSettings.swiftswiftc -parse Sources/Fluid/UI/AISettingsView+AdvancedSettings.swiftScreenshots / Video
The Advanced Prompt editor running from the ad-hoc GitHub Actions artifact for
head SHA
47368957eb4463955f1b45ec83c8c64b1ec23d3f. The editor content isscrollable while Cancel and Save remain visible in the fixed footer.
Notes
git diff --checkpasses.