Skip to content

Backport forceauth removal 20.3.x#33339

Merged
clydin merged 3 commits into
angular:20.3.xfrom
clydin:backport-forceauth-removal-20.3.x
Jun 11, 2026
Merged

Backport forceauth removal 20.3.x#33339
clydin merged 3 commits into
angular:20.3.xfrom
clydin:backport-forceauth-removal-20.3.x

Conversation

@clydin

@clydin clydin commented Jun 10, 2026

Copy link
Copy Markdown
Member

No description provided.

@clydin clydin added the target: lts This PR is targeting a version currently in long-term support label Jun 10, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes support and testing for unscoped registry authentication across the Angular CLI package metadata utilities and legacy CLI end-to-end tests. Specifically, it removes the handling of auth options in normalizeOptions and cleans up associated test cases that previously verified unscoped authentication. Feedback suggests further simplifying the createNpmConfigForAuthentication utility by completely removing the now-unused scopedAuthentication parameter and its corresponding dead code branch.

Comment thread tests/legacy-cli/e2e/utils/registry.ts Outdated
@clydin clydin force-pushed the backport-forceauth-removal-20.3.x branch 4 times, most recently from 09a2c09 to 26cb904 Compare June 10, 2026 21:06
clydin added 3 commits June 11, 2026 09:20
Remove the non-standard forceAuth option and custom parsing for unscoped registry
credentials (token, username, password, auth) in package-metadata.ts.

Since the npm CLI does not support unscoped credentials and ignores them by
default, this aligning removes the unnecessary parsing complexity. Unscoped
credentials will now behave identically to any other standard configuration
property, falling through to default configuration parsing.
@clydin clydin force-pushed the backport-forceauth-removal-20.3.x branch from 26cb904 to b076a42 Compare June 11, 2026 13:20
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 11, 2026
@clydin clydin requested a review from alan-agius4 June 11, 2026 13:46
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 11, 2026
@clydin clydin merged commit 2fb9b3b into angular:20.3.x Jun 11, 2026
32 of 33 checks passed
@clydin clydin deleted the backport-forceauth-removal-20.3.x branch June 11, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/cli target: lts This PR is targeting a version currently in long-term support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants