Skip to content

fix(@angular/build): skip semantic diagnostics for declaration files #33400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arturovt wants to merge 1 commit into from
+8 −1
Closed

fix(@angular/build): skip semantic diagnostics for declaration files #33400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/angular/build/src/tools/angular/compilation/aot-compilation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ export class AotCompilation extends AngularCompilation {

const syntactic = modes & DiagnosticModes.Syntactic;
const semantic = modes & DiagnosticModes.Semantic;
const skipLibCheck = typeScriptProgram.getCompilerOptions().skipLibCheck;

// Collect program level diagnostics
if (modes & DiagnosticModes.Option) {
Expand Down Expand Up @@ -265,13 +266,19 @@ export class AotCompilation extends AngularCompilation {
continue;
}

// When skipLibCheck is enabled (the default), declaration files are not
// type-checked, so getSemanticDiagnostics() would return nothing for them.
if (sourceFile.isDeclarationFile && skipLibCheck) {
continue;
}

yield* profileSync(
'NG_DIAGNOSTICS_SEMANTIC',
() => typeScriptProgram.getSemanticDiagnostics(sourceFile),
true,
);

// Declaration files cannot have template diagnostics
// Declaration files cannot have template diagnostics.
if (sourceFile.isDeclarationFile) {
continue;
}
Expand Down
Loading