Conversation
`InteractivityChecker.isFocusable` ignored the `inert` attribute, so
`FocusTrap` could pick an element inside an inert subtree as the first or
last tabbable element. Calling `focus()` on such an element is a no-op,
which left focus on the trap anchor and let Tab / Shift+Tab escape the
trapped region.
Add an `isInert` check that walks the ancestors with `closest('[inert]')`
and run it before the visibility check. The fix propagates through the
shared checker to `FocusTrap`, `ConfigurableFocusTrap`, `Dialog` and
`FocusKeyManager`.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InteractivityChecker.isFocusableignored theinertattribute, soFocusTrapcould pick an element inside an inert subtree as the first or last tabbable element. Callingfocus()on such an element is a no-op, which left focus on the trap anchor and let Tab / Shift+Tab escape the trapped region.Add an
isInertcheck that walks the ancestors withclosest('[inert]')and run it before the visibility check. The fix propagates through the shared checker toFocusTrap,ConfigurableFocusTrap,DialogandFocusKeyManager.StackBlitz demo of the bug: https://stackblitz.com/edit/cdk-trap-focus-with-inert?file=src%2Fmain.ts