Skip to content

fix(github-actions): verify preview artifact metadata before use #3986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ParthShethia25 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(github-actions): verify preview artifact metadata before use #3986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d084be
fix(github-actions): verify preview artifact metadata before use
ParthShethia25 Sep 18, 2026
3319043
fix(github-actions): clearer error and case-insensitive sha compare
ParthShethia25 Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions github-actions/previews/upload-artifacts-to-firebase/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ ts_project(
tsconfig = "//github-actions:tsconfig",
deps = [
":node_modules/@actions/core",
":node_modules/@octokit/rest",
":node_modules/@types/node",
"//github-actions/previews:constants_lib",
],
Expand Down
12 changes: 9 additions & 3 deletions github-actions/previews/upload-artifacts-to-firebase/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,12 @@ runs:
- name: Extracting artifact metadata
id: artifact-info
shell: bash
env:
# TRUSTED: used only to verify the artifact's claimed pull request against
# the workflow run that actually triggered this job.
GITHUB_TOKEN: '${{inputs.github-token}}'
WORKFLOW_RUN_HEAD_SHA: '${{github.event.workflow_run.head_sha}}'
GITHUB_REPOSITORY: '${{github.repository}}'
run: node ${{github.action_path}}/extract-artifact-metadata.js '${{inputs.firebase-public-dir}}'

- uses: FirebaseExtended/action-hosting-deploy@500ac625ca2dd40cbd15f7659af953801858032a # v0
Expand All @@ -100,14 +106,14 @@ runs:
expires: 10d
projectId: '${{inputs.firebase-project-id}}'
entryPoint: '${{inputs.firebase-config-dir}}'
channelId: pr-${{github.repository}}-${{steps.artifact-info.outputs.unsafe-pull-number}}-${{inputs.workflow-artifact-name}}
channelId: pr-${{github.repository}}-${{steps.artifact-info.outputs.pull-number}}-${{inputs.workflow-artifact-name}}

- uses: marocchino/sticky-pull-request-comment@5770ad5eb8f42dd2c4f34da00c94c5381e49af88 # v3.0.5
with:
header: ${{inputs.workflow-artifact-name}}
message: |
Deployed ${{inputs.workflow-artifact-name}} for ${{steps.artifact-info.outputs.unsafe-build-revision}} to: ${{steps.deploy.outputs.details_url}}
Deployed ${{inputs.workflow-artifact-name}} for ${{steps.artifact-info.outputs.build-revision}} to: ${{steps.deploy.outputs.details_url}}

_**Note**: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt._
number: ${{steps.artifact-info.outputs.unsafe-pull-number}}
number: ${{steps.artifact-info.outputs.pull-number}}
GITHUB_TOKEN: '${{inputs.github-token}}'
Loading
Loading