Skip to content

fix(core): match session directory by filesystem identity - #49557

Open
pascalandr wants to merge 2 commits into
anomalyco:devfrom
pascalandr:directory-case
Open

pascalandr wants to merge 2 commits into
anomalyco:devfrom
pascalandr:directory-case

Conversation

@pascalandr

Copy link
Copy Markdown

Issue for this PR

Closes #49556

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Directory-scoped session lists compared the stored path with exact SQL equality, so \D:\codenomad\ sessions vanished from a \D:\CodeNomad\ query on the same Windows folder. I added a shared \SessionDirectory.filter\ that finds case-variant spellings among stored directories and keeps only the ones the filesystem confirms as the same directory. Missing-directory history keeps exact spelling.

How did you verify your code works?

  • New regression in \packages/opencode/test/server/session-list.test.ts\ covering same-folder aliases and case-sensitive volumes (passes).
  • Full \session-list.test.ts: 12 passed.
  • \�un typecheck\ in \packages/core\ and \packages/opencode: passed.

Screenshots / recordings

Not a UI change.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

No duplicate PRs found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Session list misses sessions when directory case differs on Windows

1 participant