fix(core): reject invalid opaque tools at registration - #49573
Open
cestercian wants to merge 1 commit into
Open
cestercian wants to merge 1 commit into
cestercian wants to merge 1 commit into
Conversation
Validate WeakMap ownership in Tool.validate before ToolRegistry and ApplicationTools mutate registrations so a cloned or foreign tool fails with RegistrationError and leaves healthy tools materializable.
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
needs:issue
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #35963
Type of change
What does this PR do?
Invalid opaque
Toolvalues (for example a tool created by a different loaded copy of@opencode-ai/plugin) were accepted byToolRegistry.register/ApplicationTools.registerand only blew up later while materializing the Location tool catalog.This PR calls
Tool.validateon every entry before mutating registrations. A bad tool fails withRegistrationErrorand the previous catalog is left unchanged.This is the register-time validation slice called out in #35963. Broader atomic plugin reload is still out of scope.
How did you verify your code works?
bun test test/session-runner-tool-registry.test.ts test/application-tools.test.ts(31 pass)bun typecheckinpackages/corestructuredCloned opaque tool, assertRegistrationError, and confirm the healthy tool remains registered/executableScreenshots / recordings
N/A — core registry behavior, no UI change.
Checklist