refactor(core): move native compaction mechanisms into a plugin - #49575
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the change
SessionCompactionhard-coded how a provider's native compaction is performed (trigger vs endpoint, checkpoint window assembly), so this moves that mechanism into an internal plugin and leaves Core owning only the parts that must stay invariant: policy, provenance, retries, overflow fallback, and persistence.Special things to note
@opencode/aioperations; per-provider copies would have been identical.mode: "provider"policy with no registered strategy now fails withprovider.unsupported-operationbeforecompaction.started, instead of a defect after it.ctx.session.hook("compaction")) is untouched. The seam lives on the CoreSessionCompactionservice and is reachable by internal plugins only.Change outline
The new contract. Core hands a strategy the fully prepared request and gets back a replacement window;
undefinedmeans "not my mechanism".Where the mechanism went.
What
executeProviderdoes now.The plugin is the removed block, reattached through the editor.
Tests: the existing native-compaction and runner scenarios now activate the plugin and run unchanged. One new test checks the seam itself: no strategy → typed failure with nothing sent; a registered strategy's window is persisted with the catalog route's provenance and its usage, with zero HTTP calls.