Conversation
PR anomalyco#34027 introduced a type alias OpenAIResponsesReasoningReplay = Omit<OpenAIResponsesReasoningInput, 'id'> and built the replay object without the id field. The Azure/OpenAI Responses API requires that reasoning items carrying encrypted_content also carry a matching id, so omitting it causes HTTP 400 invalid_payload on continuation turns. Fixes: - Remove the Omit alias so OpenAIResponsesReasoningReplay is OpenAIResponsesReasoningInput - Add id: reasoning.id to the replay object literal in lowerMessages - Make id required (Schema.String) in OpenAIResponsesReasoningItem schema - Update the join-summary test to assert id is present - Add regression test proving the id is forwarded in the lowered input Closes anomalyco#49574
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #49574
Type of change
What does this PR do?
PR #34027 introduced OpenAIResponsesReasoningReplay = Omit<OpenAIResponsesReasoningInput, "id"> and built the replay object without id. The Responses API requires that reasoning items with encrypted_content also carry the original id. Omitting it causes HTTP 400 invalid_payload on continuation turns.
Three changes in openai-responses.ts:
The fix restores the id that lowerReasoning already correctly extracts from providerMetadata.openai.itemId but the caller was then discarding.
How did you verify your code works?
Traced the full path from lowerReasoning through the replay object construction. Updated the existing join-summary test to assert id is present. Added a regression test that directly verifies the id appears in the lowered input sent to the API.
Screenshots / recordings
No UI changes.
Checklist