fix(server): check project directory on location boot - #51287
Open
opencode-agent[bot] wants to merge 2 commits into
Open
opencode-agent[bot] wants to merge 2 commits into
opencode-agent[bot] wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked review of #51171
This PR is based on an exact mirror of
OpeOginni:folder-access-errorsateb15a9bso the Changes tab shows only the follow-up. GitHub App permissions do not allow us to create a PR against the contributor’s fork directly. This base branch is for review only; merging this PR into the mirror will not update #51171 orv2. After review, the commits can be cherry-picked onto the contributor branch or the final fix.directoryCheckoption at Brendan’s request for review. The probe now runs whenever the map hasFSUtiland the location is bare.Review caveat:
FSUtilis also present in workerd (for temporary filesystem use) and simulation. This change removes their explicit opt-outs, so a bare location in either environment now attempts a hostrealPathprobe. Existing workerd coverage only tests/api/info, not location boot. Do not treat the passing tests as proof that those environments support this behavior; resolve this concern before merging into a runtime branch.Verification: server tests (17 passed), core location/node-build tests (30 passed), scoped typechecks for core/server/client/protocol (4 passed), and oxlint (0 errors). Full
bun run checkis blocked by this host’s Node 18: Astro requires Node >=22.12 for@opencode/www.Requested by: @Brendonovich (Brendan via Slack)