Conversation
github-actions
Bot
added
needs:issue
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
When a provider returns an empty response with an
unknownfinish reason, the session prompt loop can continue creating new assistant turns indefinitely. The session remains busy and never reports a useful error to the user.This PR checks the completed assistant turn before continuing the prompt loop. If the finish reason is
unknownand the turn contains no text, reasoning, or tool output, it records aProvider returned an empty responseerror, publishes the session error, and returns the session to an idle state.Turns that contain output are left on the existing continuation path, so this change is limited to genuinely empty provider responses.
I also added a deterministic test-provider response and a CLI regression test covering the empty-response case.
How did you verify your code works?
I verified the change locally with:
bun typecheckbun test --timeout 30000 test/session/processor-effect.test.tsbun test --timeout 30000 test/cli/run/stream.transport.test.tsThe empty-response regression now exits promptly with a nonzero status and reports the expected provider error.
Screenshots / recordings
Not applicable; this is a backend/CLI behavior change.
Checklist